Skip to content

[PFA 4/n] Optimize constant pre-bound arguments #22829

Open
arnaud-lb wants to merge 4 commits into
php:masterfrom
arnaud-lb:partials-const-arg-opt
Open

[PFA 4/n] Optimize constant pre-bound arguments #22829
arnaud-lb wants to merge 4 commits into
php:masterfrom
arnaud-lb:partials-const-arg-opt

Conversation

@arnaud-lb

@arnaud-lb arnaud-lb commented Jul 20, 2026

Copy link
Copy Markdown
Member

The branch includes GH-22785, but only the commit "PFA: Optimize constant pre-bound arguments" is relevant for this PR.


PFA pre-bound arguments are bound to the generated closure's lexical vars:

function f($a, $b) {}
$f = f(1, ?);

// Generates:
$tmp = 1;
$f = function ($b) use ($tmp) {
    return f($tmp, $b);
};

Detect which pre-bound arguments are constant and burn them into the generated
closure instead:

function f($a, $b) {}
$f = f(1, ?);

// Generates:
$f = function ($b) {
    return f(1, $b);
};

This reduces the overhead during both instantiation and invocation of PFAs.


Build failures unrelated

… of the declaring opline itself

This makes the API compatible with creating partials from AST:
We can pass &ast->lineno to zend_partial_create()
The declaring op_array is used for multiple purposes:
 * Generating a PFA name
 * Finding the filename
 * Finding whether op_array is cached, and therefore whether the PFA should be
   cached too

However it's not available when evaluating a PFA AST.

Remove the declaring_op_array argument, and pass the relevant information
directly:
 * Generate the PFA name at compile time, pass it as argument to zend_partial_create()
 * Pass the filename and a cacheable flag as argument to zend_partial_create()
Pre-bound arguments are bound to the generated closure's lexical vars:

```
function f($a, $b) {}
$f = f(1, ?);

// Generates:
$tmp = 1;
$f = function ($b) use ($tmp) {
    return f($tmp, $b);
};
```

Detect which pre-bound arguments are constant and burn them into the generated
closure instead:

```
function f($a, $b) {}
$f = f(1, ?);

// Generates:
$f = function ($b) {
    return f(1, $b);
};
```
@arnaud-lb
arnaud-lb force-pushed the partials-const-arg-opt branch from 9d58c43 to b362aca Compare July 22, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant